Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak on render destroy #426

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Fix memory leak on render destroy #426

merged 1 commit into from
Jun 15, 2021

Conversation

kiryldz
Copy link
Contributor

@kiryldz kiryldz commented Jun 15, 2021

PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: #420

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-android changelog: <changelog>Fix memory leak on render destroy.</changelog>.

Summary of changes

This PR fixes memory leak for texture view renderer. It also improves overall render thread management - in some situations some essential code was not executed before killing render thread.
Additionally tests were added for MapboxSurfaceHolderRenderer.

Visuals

After fix, surface view:

image

After fix, texture view:

image

@kiryldz kiryldz added the bug 🪲 Something isn't working label Jun 15, 2021
@kiryldz kiryldz requested a review from a team June 15, 2021 12:53
@kiryldz kiryldz self-assigned this Jun 15, 2021
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kiryldz kiryldz merged commit 33f4643 into main Jun 15, 2021
@kiryldz kiryldz deleted the kdz-texture-view-leak branch June 15, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mapSurface="texture_view" memory leak ?
3 participants