[sdk-base] add default parameters to coordinate conversion functions #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiryldz
reviewed
Jul 12, 2021
sdk-base/src/main/java/com/mapbox/maps/plugin/delegates/MapCameraManagerDelegate.kt
Outdated
Show resolved
Hide resolved
Chaoba
approved these changes
Jul 12, 2021
ank27
approved these changes
Jul 12, 2021
tobrun
force-pushed
the
tvn-add-default-parms
branch
from
b4d7bf2
to
bb191c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
mapbox-maps-androidchangelog:<changelog>Add default parameters to coordinate conversion functions of MapCameraManagerDelegate#cameraForCoordinates, MapCameraManagerDelegate#cameraForCoordinateBounds and MapCameraManagerDelegate#cameraForGeometry. This overloads the functions to have a more simple API surface for developers to hook into.</changelog>.Summary of changes
Add default values to parameters of
MapCameraManagerDelegate#cameraForCoordinates,MapCameraManagerDelegate#cameraForCoordinateBoundsandMapCameraManagerDelegate#cameraForGeometry.User impact (optional)
Allows user to hook into these functions more easily, not needing them to provide null values.