Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[style-extension] Remove the expression getter/setters for source properties #568

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

pengdev
Copy link
Member

@pengdev pengdev commented Aug 16, 2021

PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-android changelog: <changelog>Remove the expression getter/setters for source properties.</changelog>.

Summary of changes

Currently we generate expression getter/setters for source properties, however, capturing from gl-native team, sources don't support expressions at all.

We need to remove the expression getter/setters for source properties.

User impact (optional)

These APIs were not supported or usable, usage of these APIs could be safely removed from the downstream projects.

@pengdev pengdev force-pushed the peng-remove-source-property-expression branch 6 times, most recently from b29688e to 6a9bb12 Compare August 16, 2021 15:52
@pengdev pengdev self-assigned this Aug 16, 2021
@pengdev pengdev force-pushed the peng-remove-source-property-expression branch from 6a9bb12 to 0f9728d Compare August 16, 2021 17:00
@kiryldz
Copy link
Contributor

kiryldz commented Aug 17, 2021

@pengdev glad to see regular CI has passed, I kicked off style test manually.

@pengdev pengdev force-pushed the peng-remove-source-property-expression branch from 0f9728d to c2ca8bd Compare August 17, 2021 08:52
@pengdev pengdev added breaking change ⚠️ bug 🪲 Something isn't working labels Aug 17, 2021
@pengdev pengdev marked this pull request as ready for review August 17, 2021 11:30
@pengdev pengdev requested a review from a team August 17, 2021 11:30
@pengdev pengdev merged commit 76e573c into main Aug 17, 2021
@pengdev pengdev deleted the peng-remove-source-property-expression branch August 17, 2021 12:45
@pengdev pengdev mentioned this pull request Aug 19, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change ⚠️ bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants