Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump gl-native to 10.0.0-rc.8, common to 18.0.0 #604

Merged
merged 3 commits into from
Sep 1, 2021
Merged

Bump gl-native to 10.0.0-rc.8, common to 18.0.0 #604

merged 3 commits into from
Sep 1, 2021

Conversation

Chaoba
Copy link
Contributor

@Chaoba Chaoba commented Sep 1, 2021

PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-android changelog: <changelog>Bump gl-native to 10.0.0-rc.8, common to 18.0.0</changelog>.

Summary of changes

User impact (optional)

Breaking changes ⚠️

  • In offline mode (set by either mapbox::common::OfflineSwitch API or on platform side), the error notifications are send if the required resources are not present locally. The volatile tiles are not considered to be required in offline.
  • Adapt setBounds to gl-js behavior: constraining of coordinates and zoom level is now stricter to prevent out of bounds map area to be visible in the viewport
  • Add HTTP interceptor API - for anyone who is using HttpServiceInterface; there is a new method called setInterceptor that should be overridden

Features ✨ and improvements 🏁

  • Improve collision detection by using runtime calculated sizes for collision boxes. Previously collision boxes' sizes are constant, they are calculated during symbol layout time by using constant zoom level
  • Improve collision detection by using runtime calculated pixelated sizes for collision circles. Previously collision circles' sizes are constant, they are calculated during symbol layout time by using constant zoom level
  • Implement 'promoteId' feature for geojson and vector sources. The feature allows to promote feature's property to a feature id, so that promoted id can be used with FeatureState API.
  • Enable instant transitions for data-driven paint layer properties

Bug fixes 🐞

  • Fix volatile tiles disappearing on "not modified" response
  • Prioritize addition of a persistent layer whose id is used for other persistent layer positions
  • Only do line breaking process for point placement labels. And if text-max-width is 0, still do general ideographic beaking checks for point labels.
  • Fix collision box's 'dynamicVerticesExt' updating in placement stage
  • Trigger map redraw when feature state changes
  • Print nothing when DisableAll set for log level

@Chaoba Chaoba added the dependencies Pull requests that update a dependency file label Sep 1, 2021
@Chaoba Chaoba self-assigned this Sep 1, 2021
@Chaoba Chaoba requested a review from a team September 1, 2021 06:07
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain why the code changes were required?

Copy link
Member

@pengdev pengdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we bring gl-native and common change log together in this PR?

@Chaoba
Copy link
Contributor Author

Chaoba commented Sep 1, 2021

@tobrun For offline part because gl-native changed the logic to send error notification; for Point init values is because we add value range for latitude and longitude.
@pengdev Add change log to pr description

@Chaoba Chaoba merged commit 4f6ae4b into main Sep 1, 2021
@Chaoba Chaoba deleted the kl-rc.8 branch September 1, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants