Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose optimizeForTerrain flag #654

Merged
merged 2 commits into from
Sep 22, 2021
Merged

Expose optimizeForTerrain flag #654

merged 2 commits into from
Sep 22, 2021

Conversation

alexander-kulikovskii
Copy link
Contributor

@alexander-kulikovskii alexander-kulikovskii commented Sep 21, 2021 •
edited
Loading

PRs must be submitted under the terms of our Contributor License Agreement CLA.

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-android changelog: <changelog>Expose optimizeForTerrain flag</changelog>.

Summary of changes

Expose optimizeForTerrain flag

User impact (optional)

@alexander-kulikovskii alexander-kulikovskii requested a review from a team September 21, 2021 15:49
@alexander-kulikovskii alexander-kulikovskii self-assigned this Sep 21, 2021
kiryldz
kiryldz approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@kiryldz kiryldz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with small comment from @axti otherwise LGTM

@alexander-kulikovskii alexander-kulikovskii merged commit dc5cbd0 into main Sep 22, 2021
@alexander-kulikovskii alexander-kulikovskii deleted the kas-expose-optimizeForTerrain-flag branch September 22, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axti axti axti approved these changes

@kiryldz kiryldz kiryldz approved these changes

Assignees

@alexander-kulikovskii alexander-kulikovskii

Labels
feature 🍏
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexander-kulikovskii @axti @kiryldz