Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send turnstiles for Snapshotter usage #920

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Conversation

Chaoba
Copy link
Contributor

@Chaoba Chaoba commented Nov 29, 2021

Summary of changes

This PR adds the function to send turnstiles for snapshotter.

User impact (optional)

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Optimize code for java consumption (@JvmOverloads, @file:JvmName, etc).
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-android changelog: <changelog>Send turnstiles for Snapshotter usage</changelog>.
  • If this PR is a v10.[version] release branch fix / enhancement, merge it to main firstly and then port to v10.[version] release branch.

Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

PRs must be submitted under the terms of our Contributor License Agreement CLA.

@Chaoba Chaoba added the bug 🪲 Something isn't working label Nov 29, 2021
@Chaoba Chaoba requested a review from a team as a code owner November 29, 2021 05:15
@Chaoba Chaoba self-assigned this Nov 29, 2021
@@ -48,6 +52,7 @@ open class Snapshotter {
snapshotOverlayOptions = overlayOptions
pixelRatio = context.resources.displayMetrics.density
coreSnapshotter = MapSnapshotter(options)
dispatchTelemetryTurnstileEvent(context, options)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so new turnstile event is triggered each time when Snapshotter is created? I'm not sure it's what we want...
@tobrun shouldn't it be some other telemetry event?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same with V9.

@Chaoba Chaoba merged commit ec778c7 into main Dec 16, 2021
@Chaoba Chaoba deleted the kl-turnstile-snapshotter branch December 16, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants