-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tile requests delay apis #960
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pengdev
reviewed
Dec 7, 2021
...ion-style/src/main/java/com/mapbox/maps/extension/style/sources/generated/RasterDemSource.kt
Outdated
Show resolved
Hide resolved
pengdev
reviewed
Dec 7, 2021
...ion-style/src/main/java/com/mapbox/maps/extension/style/sources/generated/RasterDemSource.kt
Outdated
Show resolved
Hide resolved
ank27
force-pushed
the
ak-tile-delay-api
branch
from
December 8, 2021 09:40
c50337c
to
20ebdd7
Compare
ank27
force-pushed
the
ak-tile-delay-api
branch
from
December 8, 2021 09:46
20ebdd7
to
9f5383d
Compare
ank27
force-pushed
the
ak-tile-delay-api
branch
from
December 8, 2021 11:58
6566344
to
50a195f
Compare
pengdev
reviewed
Dec 8, 2021
app/src/main/java/com/mapbox/maps/testapp/examples/style/TileJsonActivity.kt
Outdated
Show resolved
Hide resolved
ank27
force-pushed
the
ak-tile-delay-api
branch
from
December 8, 2021 14:31
50a195f
to
61f0e09
Compare
tobrun
approved these changes
Dec 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very small nit on the test code, looks good otherwise.
Thank you for adding the visual comparison to the PR!
app/src/main/java/com/mapbox/maps/testapp/examples/style/TileJsonActivity.kt
Outdated
Show resolved
Hide resolved
Chaoba
reviewed
Dec 9, 2021
app/src/main/java/com/mapbox/maps/testapp/examples/style/TileJsonActivity.kt
Outdated
Show resolved
Hide resolved
.../src/androidTest/java/com/mapbox/maps/testapp/style/sources/generated/RasterDemSourceTest.kt
Show resolved
Hide resolved
pengdev
approved these changes
Dec 9, 2021
ank27
force-pushed
the
ak-tile-delay-api
branch
from
December 9, 2021 10:11
61f0e09
to
c910452
Compare
yunikkk
approved these changes
Dec 9, 2021
Chaoba
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Introduce
tile-requests-delay
andtile-network-requests-delay
APIs to set delay in tile requests for vector, raster and raster-dem sources.The
tile-requests-delay
property:The
tile-network-requests-delay
property:tile_request_no_delay.mp4
tile_request_delay_5sec.mp4
User impact (optional)
Pull request checklist:
@JvmOverloads
,@file:JvmName
, etc).mapbox-maps-android
changelog:<changelog>Added "tile-requests-delay" and "tile-network-requests-delay" source properties for tile requests delay.</changelog>
.v10.3
release branch fix / enhancement, merge it tomain
firstly and then port tov10.3
release branch.Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
PRs must be submitted under the terms of our Contributor License Agreement CLA.