Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable drag annotation while changing the annotation to draggable in long click #990

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

Chaoba
Copy link
Contributor

@Chaoba Chaoba commented Dec 14, 2021

Summary of changes

Remove the checking for isDraggable in startDragging, so that if users change the draggable to true in the long click, the dragging annotation could be dragged in the following drag events.

User impact (optional)

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Optimize code for java consumption (@JvmOverloads, @file:JvmName, etc).
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-android changelog: <changelog>Enable drag annotation while changing the annotation to draggable in long click</changelog>.
  • If this PR is a v10.[version] release branch fix / enhancement, merge it to main firstly and then port to v10.[version] release branch.

Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

PRs must be submitted under the terms of our Contributor License Agreement CLA.

@Chaoba Chaoba requested a review from a team as a code owner December 14, 2021 03:13
@Chaoba Chaoba self-assigned this Dec 14, 2021
@Chaoba Chaoba added the bug 🪲 Something isn't working label Dec 14, 2021
@Chaoba Chaoba merged commit 1f5b9f8 into main Dec 16, 2021
@Chaoba Chaoba deleted the kl-drag-annotation-in-long-click branch December 16, 2021 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants