Vanishing route line is not animated

[LukasPaczos]

When testing 1.0.0-qa.2020.w25 I'm noticing that the vanishing route line's progress change is not animated:

/cc @cafesilencio @abhishek1508 @Guardiola31337

[cafesilencio]

This is confusing. When I run the basic activity from master this is what I see:

[cafesilencio]

I can see on a longer route it looks a bit more choppy. The animation duration is 900ms. Each animation 'tick' will make 3 calls to update the gradient for the shield line, the route line and the traffic line. There are many 'ticks' in every 900ms animation window. @LukasPaczos do you have any insight into what happens on the map side? Could some of the calls be getting ignored because there are too many in short period of time?

[LukasPaczos]

Could some of the calls be getting ignored because there are too many in short period of time?

The map render will most likely coalesce the calls if they are coming in faster than we are able to render, but it would not result in a jump. It would still be animated as smoothly as possible, but missing a couple of frames.

[cafesilencio]

I see the value animator updating all three route lines about 90 times per second. That's about every 11 ms.

[Guardiola31337]

This is easily reproducible running the ReplayActivity from the examples test app 👀

cc @cafesilencio @LukasPaczos

[cafesilencio]

Looks like we need to wait for a maps gl update. There was a slack conversation about it.

…

On Wed, Jun 24, 2020 at 8:39 AM Pablo Guardiola ***@***.***> wrote: This is easily reproducible running the ReplayActivity from the examples test app 👀 [image: replay_location_engine_activity_vanishing_route_line_not_animated] <https://user-images.githubusercontent.com/1668582/85586876-4b298b80-b60f-11ea-9f99-3bf6c05faa7e.gif> cc @cafesilencio <https://github.com/cafesilencio> @LukasPaczos <https://github.com/LukasPaczos> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3214 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AARFIWXLMJQN7Z67TS4Y6YLRYIM23ANCNFSM4OE4V5GQ> .

[LukasPaczos]

Yes, looks like this also depends on mapbox/mapbox-gl-js#9694.

/cc @1ec5 @captainbarbosa

[Guardiola31337]

Cross-posting from #3284 (review) so these comments don't get lost

Noting a couple interesting things that I found though:

• We keep vanishing the route line when off-route is happening 👀

• When putting the app in the background and bringing it back to the foreground the vanishing line is not updated - note how it catches up quickly 👀

It seems that route progress updates are stopped when in the background.

Also noticed that in that example (FragmentNavigationActivity) the route line is not re-drawn after putting the app in the background and bringing it back to the foreground but that may be the specific setup from that example.

Feel free to merge here and cut separate tickets to investigate ☝️ further.

cc @LukasPaczos @cafesilencio

[cafesilencio]

This should be resolved since getting the maps GL update.

[cafesilencio]

Closing this issue as I believe it's resolved.