Fix route refresh not starting #4831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
added
bug
kmadsen
reviewed
Sep 16, 2021
libnavigation-core/src/main/java/com/mapbox/navigation/core/MapboxNavigation.kt
Show resolved
Hide resolved
kmadsen
reviewed
Sep 16, 2021
| @@ -408,7 +408,6 @@ class MapboxNavigation( | |||
| tripSession, | |||
| logger | |||
| ) | |||
| routeRefreshController.restart() | |||
There was a problem hiding this comment.
💯 like how this way can delete some interactions
kmadsen
reviewed
Sep 16, 2021
| ?.takeIf { it.isUuidValidForRefresh() } | ||
| if (route != null) { | ||
| private fun refreshRoute(route: DirectionsRoute) { | ||
| val isValid = route.routeOptions()?.enableRefresh() == true && route.isUuidValidForRefresh() |
There was a problem hiding this comment.
I'm a little on the fence of having it come from the external caller. The tripSession is still needed with route progress
There was a problem hiding this comment.
IMO we should just call routeRefreshController.restart() without the route
RouteRefreshController depends on directionsSession so it can access the primary route on its own.
Also, that reduces the tests you need to add to the overpowered MapboxNavigation.
kmadsen
reviewed
Sep 16, 2021
| @@ -576,7 +575,6 @@ class MapboxNavigation( | |||
| rerouteController?.interrupt() | |||
| routeAlternativesController.interrupt() | |||
| directionsSession.setRoutes(routes, initialLegIndex) | |||
| routeRefreshController.restart() | |||
LukasPaczos
force-pushed
the
lp-fix-refresh-start-timing
branch
from
4155ade
to
a53a167
Compare
Closed
kmadsen
approved these changes
Sep 16, 2021
…nsSession the source of truth
LukasPaczos
force-pushed
the
lp-fix-refresh-start-timing
branch
from
a53a167
to
8b6b1d5
Compare
LukasPaczos
added a commit
that referenced
this pull request
Sep 16, 2021
* fix route refresh not starting * removed route from the TripSession interface to clearly make DirectionsSession the source of truth
LukasPaczos
removed
the
needs backporting
abhishek1508
pushed a commit
that referenced
this pull request
Sep 16, 2021
* fix route refresh not starting * removed route from the TripSession interface to clearly make DirectionsSession the source of truth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #4829. Fixes a regression potentially from #4755.
A route is not set synchronously in the
MapboxTripSessionanymore, so we cannot use a synchronous getter for it in theRouteRefreshController.We could potentially use a synchronous getter from
MapboxDirectionsSessioninstead as #4830 proposes but it's exposed to the same risk as the previousMapboxTripSessiongetter - route setting is run on a callback (RoutesObserver) and we don't guarantee that the route setting process is synchronous. We could changeMapboxDirectionsSessionto work asynchronously in the future and run into the same exact regression.This PR instead uses the
RoutesObserverto restart the refresh timer.Changelog