-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update NN to v90.0.0, Maps SDK to v10.4.0-beta.1 and Common SDK to v21.2.0-beta.1 #5552
Conversation
455d210
to
8b06720
Compare
This PR depends on mapbox/mapbox-java#1376 and a release of cc @kmadsen |
This also needs a fix in |
...ator/src/main/java/com/mapbox/navigation/navigator/internal/router/RouterInterfaceAdapter.kt
Outdated
Show resolved
Hide resolved
...ator/src/main/java/com/mapbox/navigation/navigator/internal/router/RouterInterfaceAdapter.kt
Outdated
Show resolved
Hide resolved
libnavigation-core/src/main/java/com/mapbox/navigation/core/MapboxNavigation.kt
Outdated
Show resolved
Hide resolved
...ain/java/com/mapbox/navigation/base/trip/model/roadobject/railwaycrossing/RailwayCrossing.kt
Outdated
Show resolved
Hide resolved
@@ -124,12 +123,39 @@ class RouterInterfaceAdapter( | |||
|
|||
override fun getRouteRefresh( | |||
options: RouteRefreshOptions, | |||
route: String, | |||
callback: RouterRefreshCallback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see in NN release notes why they remove the route
param, do you know @LukasPaczos ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nav Native does not swap the annotation on the instance itself, so it doesn't need the route reference anymore. Refs https://github.com/mapbox/mapbox-navigation-native/pull/5420#discussion_r822651362.
mapbox/mapbox-java#1377 adds handling for the unintentional encoding that NN introduced in the |
cdfd145
to
08392f6
Compare
This is ready for a final review. |
08392f6
to
14ea491
Compare
|
14ea491
to
804f95b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
804f95b
to
cd60dba
Compare
Turns out that Nav Native unintentionally bumped the Kotlin compiler version to 1.6.10 which is incompatible with The
but also fails to generate the diffs correctly, for example generates public API description as:
with random The project seems to be running okay in debug and release variants, even though some helper Kotlin classes from Nav Native were compiled Kotlin 1.6.10, but this is just with my limited testing. In think the safest approach at this point is to wait for Nav Native to revert the Kotlin compiler bump in the upcoming release, and merge this PR only then. After that, we can start looking into building an upgrade strategy for Kotlin 1.6. cc @mskurydin |
bdcbfff
to
2e4e207
Compare
2e4e207
to
489d8a4
Compare
Updated to NN |
Description
With this release Nav Native brings 2 breaking changes that this PR tries to integrate:
mapbox-java
version that includes added railway crossings to step intersection mapbox-java#1375 as well.