Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed RouteOptionsUpdater to use snapping_include_closures=true for origin of each re-route request #6050

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

LukasPaczos
Copy link
Member

Description

Closes #5664.

Adding snapping_include_closures=true resolves an occasional problem that returned a route in opposite direction or on parallel road when a driver caused a re-route by entering a closed section of a road. When present, this issue typically caused a loop of reroutes until a driver left the closed section. With snapping_include_closures=true, we'll still try to navigate out of the closed section as soon as possible but without continuous re-routes that could be impossible to execute.

cc @mandeepsandhu

@LukasPaczos LukasPaczos added the improvement Improvement for an existing feature. label Jul 13, 2022
@LukasPaczos LukasPaczos requested a review from a team as a code owner July 13, 2022 10:30
@LukasPaczos LukasPaczos force-pushed the lp-5664-snapping-closures-reroute branch 2 times, most recently from d1c8db4 to 120d10d Compare July 13, 2022 10:36
@LukasPaczos LukasPaczos force-pushed the lp-5664-snapping-closures-reroute branch from 120d10d to 175e5d3 Compare July 13, 2022 10:59
Copy link
Contributor

@RingerJK RingerJK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could you change the very top string doc of RouteOptionsUpdater: Updater is used for *Reroute* and *Route Alternatives* flow.. We don't use it for Alternatives anymore

@LukasPaczos LukasPaczos force-pushed the lp-5664-snapping-closures-reroute branch from 175e5d3 to 8c44abb Compare July 13, 2022 11:18
@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #6050 (a7ec045) into main (ae33a48) will increase coverage by 0.00%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #6050   +/-   ##
=========================================
  Coverage     68.01%   68.02%           
  Complexity     4065     4065           
=========================================
  Files           611      611           
  Lines         24885    24889    +4     
  Branches       2944     2944           
=========================================
+ Hits          16926    16930    +4     
  Misses         6839     6839           
  Partials       1120     1120           
Impacted Files Coverage Δ
...avigation/core/routeoptions/RouteOptionsUpdater.kt 87.50% <87.50%> (+0.37%) ⬆️

@LukasPaczos LukasPaczos force-pushed the lp-5664-snapping-closures-reroute branch from 8c44abb to a7ec045 Compare July 13, 2022 12:33
@LukasPaczos LukasPaczos merged commit 266e8ff into main Jul 13, 2022
@LukasPaczos LukasPaczos deleted the lp-5664-snapping-closures-reroute branch July 13, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement for an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable snapping to closure for the origin of the re-route by default
3 participants