enable snapping_include_static_closure by default for reroute #6164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzinad
force-pushed
the
dd-6119-snapping-include-static-closures
branch
from
46c199b
to
65d1370
Compare
There was a problem hiding this comment.
Tests are ❌
com.******.navigation.core.routeoptions.RouteOptionsUpdaterTest$SnappingClosuresOptionsParameterized > snappingClosuresOptions[4] FAILED
java.lang.AssertionError at RouteOptionsUpdaterTest.kt:554
com.******.navigation.core.routeoptions.RouteOptionsUpdaterTest$SnappingStaticClosuresOptionsParameterized > snappingClosuresOptions[4] FAILED
java.lang.AssertionError at RouteOptionsUpdaterTest.kt:675
910 tests completed, 2 failed, 2 skipped
> Task :libnavigation-core:testDebugUnitTest FAILED
libnavigation-core/src/main/java/com/mapbox/navigation/core/routeoptions/RouteOptionsUpdater.kt
Outdated
Show resolved
Hide resolved
| @@ -100,32 +100,15 @@ class RouteOptionsUpdater { | |||
| it.addAll(approachesList.subList(index, coordinatesList.size)) | |||
| } | |||
| } | |||
| ).apply { | |||
| if (routeOptions.profile() == DirectionsCriteria.PROFILE_DRIVING_TRAFFIC) { | |||
There was a problem hiding this comment.
Was this removed on purpose? Look at #6147
There was a problem hiding this comment.
Rebase issues. Moved it back.
LukasPaczos
reviewed
Aug 15, 2022
Comment on lines
104
to
107
| .snappingIncludeClosuresList( | ||
| routeOptions.snappingIncludeClosuresList() | ||
| .withFirstTrue(remainingWaypoints, index, coordinatesList.size) | ||
| ) |
There was a problem hiding this comment.
We cannot rely on nullability when adding snappingIncludeClosuresList and snappingIncludeStaticClosuresList. We do want to add these parameters to a reroute request even if they were not part of the original request. That's why we need to check for the profile.
There was a problem hiding this comment.
I returned the profile check so it should work as expected now.
LukasPaczos
changed the title
dzinad
force-pushed
the
dd-6119-snapping-include-static-closures
branch
from
65d1370
to
c7d3817
Compare
VysotskiVadim
approved these changes
Aug 16, 2022
...gation-core/src/test/java/com/mapbox/navigation/core/routeoptions/RouteOptionsUpdaterTest.kt
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #6164 +/- ##
============================================
- Coverage 68.91% 68.86% -0.05%
+ Complexity 4258 4256 -2
============================================
Files 639 639
Lines 25663 25666 +3
Branches 3004 3004
============================================
- Hits 17686 17676 -10
- Misses 6830 6845 +15
+ Partials 1147 1145 -2
|
dzinad
force-pushed
the
dd-6119-snapping-include-static-closures
branch
from
c7d3817
to
f0ea85e
Compare
LukasPaczos
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6119.