Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android Auto] Bump maps version and remove @MapboxExperimental #6588

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

kmadsen
Copy link
Contributor

@kmadsen kmadsen commented Nov 11, 2022

Description

This pull request needed to be rebased onto a separate release app to get away from all the development changes.

So we should merge this one first #6605. All the issues in this pull requests comments have been resolved.

@kmadsen kmadsen added the Android Auto Bugs, improvements and feature requests on Android Auto. label Nov 11, 2022
@kmadsen kmadsen requested a review from a team as a code owner November 11, 2022 17:45
@kmadsen kmadsen force-pushed the km-NAVAND-885-remove-experimental branch from 01e2839 to 37b4245 Compare November 11, 2022 17:48
@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #6588 (65afdcc) into main (5cdc300) will not change coverage.
The diff coverage is n/a.

❗ Current head 65afdcc differs from pull request most recent head 3c1046a. Consider uploading reports for the commit 3c1046a to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #6588   +/-   ##
=========================================
  Coverage     72.40%   72.40%           
  Complexity     5322     5322           
=========================================
  Files           752      752           
  Lines         29066    29066           
  Branches       3439     3439           
=========================================
  Hits          21045    21045           
  Misses         6640     6640           
  Partials       1381     1381           

@kmadsen kmadsen marked this pull request as draft November 11, 2022 18:50
@kmadsen
Copy link
Contributor Author

kmadsen commented Nov 11, 2022

There are some issues with the BitmapWidget offsets and translations

Screen Shot 2022-11-11 at 2 18 40 PM

Screen Shot 2022-11-11 at 10 42 48 AM

@kmadsen
Copy link
Contributor Author

kmadsen commented Nov 11, 2022

Another issue while trying to test with qa-test-app

e: /Users/kylemadsen/Development/mapbox/mapbox-navigation-android/qa-test-app/src/main/java/com/mapbox/navigation/qa_test_app/lifecycle/DropInStartReplayButton.kt: (35, 30): Overload resolution ambiguity: 
public fun MapboxNavigation.flowTripSessionState(): Flow<TripSessionState> defined in com.mapbox.navigation.core.internal.extensions
public fun MapboxNavigation.flowTripSessionState(): Flow<TripSessionState> defined in com.mapbox.navigation.core.internal.extensions

@kmadsen
Copy link
Contributor Author

kmadsen commented Nov 12, 2022

2022-11-11 16:47:09.680  5446-5446  AndroidRuntime          com...vigation.examples.androidauto  E  FATAL EXCEPTION: main
                                                                                                    Process: com.mapbox.navigation.examples.androidauto, PID: 5446
                                                                                                    kotlin.UninitializedPropertyAccessException: lateinit property application has not been initialized
                                                                                                    	at com.mapbox.search.MapboxSearchSdk.createAnalyticsService(MapboxSearchSdk.kt:112)
                                                                                                    	at com.mapbox.search.SearchEngineFactory.createSearchEngineWithBuiltInDataProviders(SearchEngineFactory.kt:41)
                                                                                                    	at com.mapbox.search.SearchEngine$Companion.createSearchEngineWithBuiltInDataProviders(SearchEngine.kt:416)
                                                                                                    	at com.mapbox.search.SearchEngine$Companion.createSearchEngineWithBuiltInDataProviders$default(SearchEngine.kt:410)
                                                                                                    	at com.mapbox.androidauto.internal.search.CarPlaceSearchImpl.onAttached(CarPlaceSearchImpl.kt:31)
                                                                                                    	at com.mapbox.navigation.core.lifecycle.MapboxNavigationOwner.register(MapboxNavigationOwner.kt:49)

Taking note of another issue initializing search

@kmadsen kmadsen force-pushed the km-NAVAND-885-remove-experimental branch 4 times, most recently from f776c4c to 79ca715 Compare November 14, 2022 17:48
@kmadsen kmadsen marked this pull request as ready for review November 14, 2022 17:59
@kmadsen kmadsen changed the base branch from main to km-qa-test-app-for-androidauto November 14, 2022 18:02
@kmadsen kmadsen force-pushed the km-qa-test-app-for-androidauto branch from dbb8e83 to 65afdcc Compare November 14, 2022 21:02
@kmadsen kmadsen force-pushed the km-NAVAND-885-remove-experimental branch from 79ca715 to e74af2c Compare November 14, 2022 21:13
Base automatically changed from km-qa-test-app-for-androidauto to main November 15, 2022 00:12
@kmadsen kmadsen force-pushed the km-NAVAND-885-remove-experimental branch from e74af2c to 3c1046a Compare November 15, 2022 00:20
@kmadsen kmadsen enabled auto-merge (squash) November 15, 2022 00:22
@kmadsen kmadsen merged commit f528c30 into main Nov 15, 2022
@kmadsen kmadsen deleted the km-NAVAND-885-remove-experimental branch November 15, 2022 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Auto Bugs, improvements and feature requests on Android Auto.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants