Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completion handlers to camera change operations #2192

Merged
merged 3 commits into from
Jul 27, 2019

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Jul 26, 2019

Fixed deprecation warnings introduced in mapbox/mapbox-gl-native#14959 and triggered by upgrading to map SDK v5.2.0 and fixes a to-do item related to mapbox/mapbox-gl-native#14381.

/ref #2188 (comment)
/cc @mapbox/navigation-ios

@1ec5 1ec5 added the build Issues related to builds and dependency management. label Jul 26, 2019
@1ec5 1ec5 added this to the v0.36.0 milestone Jul 26, 2019
@1ec5 1ec5 requested a review from JThramer July 26, 2019 22:21
@1ec5 1ec5 self-assigned this Jul 26, 2019
1ec5 added 2 commits July 26, 2019 15:23
Fixes compiler warnings about deprecated method usage.
Copy link
Contributor

@friedbunny friedbunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So complete!

@1ec5 1ec5 merged commit 02f204c into master Jul 27, 2019
@1ec5 1ec5 deleted the 1ec5-camera-completion branch July 27, 2019 00:22
Copy link
Contributor

@JThramer JThramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@1ec5 1ec5 mentioned this pull request Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to builds and dependency management.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants