add test - filtering by scale denominator on layer level #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talaj
force-pushed
the
scale-denom-layer-test
branch
from
88dc74b
to
26faa58
Compare
talaj
force-pushed
the
scale-denom-layer-test
branch
from
26faa58
to
e4c13d2
Compare
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
==========================================
- Coverage 60.17% 60.12% -0.06%
==========================================
Files 30 30
Lines 2142 2144 +2
==========================================
Hits 1289 1289
- Misses 853 855 +2
Continue to review full report at Codecov.
|
|
Thank you for the test additions @talaj - per #243 (comment) there is one unrelated osx failure. I will merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test covers filtering layers by scale denominator and shows it works. In #230 is claimed otherwise.