Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path.join so that pkg could auto detect assets #80

Merged
merged 3 commits into from
Aug 6, 2018

Conversation

jingsam
Copy link
Collaborator

@jingsam jingsam commented Dec 11, 2017

pkg could auto package assets if we use path.join(__dirname, 'aaa.txt')

@mapsam
Copy link
Contributor

mapsam commented Jan 9, 2018

Thanks @jingsam - could you provide the error that pkg gives so I can try to recreate?

@jingsam
Copy link
Collaborator Author

jingsam commented Jan 10, 2018

This error is not display when you package it, but when you run your packaged app, it complaints:

Error: File '/**/foxgis-server-lite/node_modules/@mapbox/mbtiles/lib/schema.sql' was not included into executable at compilation stage. Please recompile adding it as asset or script.
    at error_ENOENT (pkg/prelude/bootstrap.js:422:17)
    at readFileFromSnapshot (pkg/prelude/bootstrap.js:646:29)
    at Object.fs.readFileSync (pkg/prelude/bootstrap.js:689:18)
    at Object.<anonymous> (/snapshot/foxgis-server-lite/node_modules/@mapbox/mbtiles/lib/mbtiles.js:28:21)
    at Module._compile (pkg/prelude/bootstrap.js:1243:22)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.require (module.js:497:17)

@jingsam
Copy link
Collaborator Author

jingsam commented Mar 26, 2018

ping @mapsam

@mapsam
Copy link
Contributor

mapsam commented Mar 26, 2018

@jingsam can you rebase against master to get tests passing again? Looks like the utils folder was removed in #77

@jingsam
Copy link
Collaborator Author

jingsam commented Aug 4, 2018

ping @mapsam

@mapsam
Copy link
Contributor

mapsam commented Aug 6, 2018

Thanks @jingsam - looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants