-
-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update node to 16 #781
Conversation
Thanks for taking the time to look into this. Currently, we recommend using |
If you update node and npm, please also edit https://github.com/maplibre/maplibre-gl-js/blob/main/CONTRIBUTING.md |
Bundle size report: Size Change: 0 B
ℹ️ View DetailsNo major changes |
The upstream node-canvas package supposedly have node 16 support since 2.8, but there appears to be some issues. When the upsteam is resolved, I'll try to run the maplibre-gl-js tests again. |
e21c931
to
232e392
Compare
232e392
to
6f8e71e
Compare
@wipfli I bumped node-canvas and gl because their newer versions does have node 16 support. Can we rerun the tests? |
Awesome! Let me know if anything is holding this back. |
I think the only thing holding this back is my hesitation to upgrade my dev env to node 16... :-( |
Great :) nvm to the rescue. I'll rebase the affected pr's to this branch then. |
We'd appreciate any extra hands :-) |
Alright, that would be great actually :) |
Added as a maintainer. Godspeed! |
Welcome to MapLibre, Birk! |
The current Node LTS is 16, bundling the npm v8 which use package-lock.json v2 format.
Update node to 16