Boost MSVC 2019 Compile Issues

[dpaulat]

vendor/boost has compile issues when compiling with MSVC 2019. See mapbox/mapbox-gl-native-boost#2. I can think of two potential resolutions:

1. mapbox-gl-native-boost needs forked
2. Use a package manager (e.g., conan)

The latter could also help with other missing dependencies (e.g., zlib), if the project wants to move in this direction.

[kiibimees]

Conan might introduce annoying yet-another-tool-dependency. Forking and updating mapbox-gl-native-boost seems to be a clean enough soution, IMHO. Any dependency to Mapbox should be removed in the future anyway, I guess.

[kiibimees]

Or why not just copy and commit all boost files directly into this repository? Boost itselt doesn't have a 'release' repo and I don't see any good reason why should we create it and make things more compicated. It's a header-only usage.

[dpaulat]

I think your suggestion of forking mapbox-gl-native-boost is the most straightforward solution. It's a vendor dependency, following the pattern of most other dependencies in the vendor directory, would make sense to have it a submodule. It makes it easier to interchange dependencies, and there could be a point in the future where it's more than header-only usage.

…

On Fri, Dec 10, 2021 at 12:48 AM kiibimees ***@***.***> wrote: Or why not just copy and commit all boost files directly into this repository? Boost itselt doesn't have a 'release' repo and I don't see any good reason why should we create it and make things more compicated. It's a header-only usage. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#124 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAWAXTNJO3IYQE64I52MSBLUQGPDJANCNFSM5AFK244Q> .

[kiibimees]

Sure, fine by me. Could somebody with enough ranking do it in the near future? Right now MSVC 2019 build fails because of that.

[dpaulat]

If you're looking for a temporary solution while waiting for the fork, I fixed the immediate issue in a fork, without upgrading boost:

https://github.com/dpaulat/mapbox-gl-native-boost

[kiibimees]

Well, it would be nice if I could just point QtLocation submodule to a maplibre state where it is fixed. In that case one can compile the plugin more easily. An super-cool would be if somebody could review my merge request. That makes short URL-s and styles also work with the plugin. Then I would be very happy for the start. Later, I would like to handle style types (streets, hybrid, terrain, etc) more correctly but that is not a showstopper anymore.

[kiibimees]

It would be nice if somebody with enough ranking, fork the mapbox boost repo and add at least the MSVC fix.

Anybody?

[kiibimees]

I would be so much appreciated if somebody could fork the Boost repo and apply necessary fixes. Anybody?

[dpaulat]

Resolved by #231 (commit 1398333)