Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update shader_defines.hpp to use enum class #2888

Open
louwers opened this issue Oct 1, 2024 · 0 comments
Open

Update shader_defines.hpp to use enum class #2888

louwers opened this issue Oct 1, 2024 · 0 comments
Labels
cpp-core good first issue Good for newcomers

Comments

@louwers
Copy link
Collaborator

louwers commented Oct 1, 2024

Everything else in the file uses enum. I would prefer keeping them the same so it's either updating all of them to enum class now or later.

Originally posted by @adrian-cojocaru in #2836 (comment)
@louwers louwers added good first issue Good for newcomers cpp-core labels Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cpp-core good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@louwers