Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use drawables for location indicator layer #2836

Merged

Conversation

adrian-cojocaru
Copy link
Collaborator

@adrian-cojocaru adrian-cojocaru commented Sep 16, 2024

This PR adds guards for OpenGL code in src/mbgl/renderer/layers/render_location_indicator_layer.cpp and adds an alternative implementation using drawables for the location indicator elements.

  • added a set of new simple shaders: CommonShader, CommonTexturedShader
  • added mipmapping and runtime mip generation
  • added texture sampler anisotropy value/check

Closes #1654

adrian-cojocaru and others added 30 commits August 7, 2024 20:45
@adrian-cojocaru adrian-cojocaru self-assigned this Sep 16, 2024
@adrian-cojocaru adrian-cojocaru marked this pull request as draft September 16, 2024 11:21
Copy link

github-actions bot commented Sep 16, 2024

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2836-compared-to-main.txt

Copy link

github-actions bot commented Sep 16, 2024

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +712  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2836-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +28% +32.6Mi  +426% +25.4Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2836-compared-to-legacy.txt

Copy link

github-actions bot commented Sep 16, 2024

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            +0.0003         -0.0000             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2836-compared-to-main.txt

@adrian-cojocaru adrian-cojocaru marked this pull request as ready for review September 16, 2024 15:16
@adrian-cojocaru adrian-cojocaru merged commit 156872f into maplibre:main Oct 8, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Location Indicator Layer
5 participants