Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename MaptilerFileSource to MBTilesFileSource #198

Merged
merged 2 commits into from
Apr 7, 2022

Conversation

brendan-ward
Copy link
Collaborator

This achieves the first part of #32, renaming MaptilerFileSource to MBTilesFileSource, since this file source is about working with local mbtiles files (nothing specific to Maptiler). Does this need to be listed as a breaking change?

Includes minor cleanup to ensure it is declared once and leverage the existing constant MBTILES_PROTOCOL.

@brendan-ward
Copy link
Collaborator Author

What is needed in order for this PR to proceed? Do we need to alias MBTilesFileSource to MaptilerFileSource so as to avoid breaking downstream users that use the previous class?

@ntadej
Copy link
Collaborator

ntadej commented Apr 6, 2022

Sorry for the delay in this one. Do we actually expect many clients of it actually? I'm surprised that none of the platfom needed to be updated. It also does not seem like a public API to me. I think we're fine to rename.

May I ask you to rebase so we run the latest tests? Then I think it would be OK to be merged.

@brendan-ward
Copy link
Collaborator Author

Correct: it is not a public API, just an internal class. I believe this was donated by Maptiler when maplibre-gl-native was originally forked from Mapbox and hasn't been more broadly used since then. For building a static rendering engine, it is quite handy, since it lets us use MBtiles files directly on disk.

@ntadej
Copy link
Collaborator

ntadej commented Apr 6, 2022

Thanks! Once the pipeline passes I'll merge this one (and the other one).

Sorry again for the delay!

@ntadej ntadej merged commit 539d81a into maplibre:main Apr 7, 2022
@brendan-ward brendan-ward deleted the issue32 branch April 7, 2022 15:48
keith pushed a commit to lyft/maplibre-gl-native that referenced this pull request Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants