Fix render tests

[wipfli]

This pull request reverts some changes of #270 which broke the render tests.

Probably the syntax has to be adapted.

[wipfli]

Instead of running all render tests, one can only run the ones which currently fail on main with a run-render-tests.sh script on linux which might look like this:

#!/bin/bash
cmake --build build -j $(nproc 2>/dev/null || sysctl -n hw.ncpu 2>/dev/null)
./build/mbgl-render-test-runner --manifestPath metrics/linux-clang8-release-style.json --filter "render-tests/symbol-placement/line-overscaled"
./build/mbgl-render-test-runner --manifestPath metrics/linux-clang8-release-style.json --filter "render-tests/symbol-visibility/visible"
./build/mbgl-render-test-runner --manifestPath metrics/linux-clang8-release-style.json --filter "render-tests/text-variable-anchor/rotated-offset"
./build/mbgl-render-test-runner --manifestPath metrics/linux-clang8-release-style.json --filter "render-tests/text-variable-anchor/all-anchors-tile-map-mode"
./build/mbgl-render-test-runner --manifestPath metrics/linux-clang8-release-style.json --filter "query-tests/circle-radius/tile-boundary"
./build/mbgl-render-test-runner --manifestPath metrics/linux-clang8-release-style.json --filter "query-tests/fill-features-in/default"
./build/mbgl-render-test-runner --manifestPath metrics/linux-clang8-release-style.json --filter "query-tests/invisible-features/zero-opacity"
./build/mbgl-render-test-runner --manifestPath metrics/linux-clang8-release-style.json --filter "query-tests/edge-cases/box-cutting-antimeridian-z1"
./build/mbgl-render-test-runner --manifestPath metrics/linux-clang8-release-style.json --filter "query-tests/edge-cases/box-cutting-antimeridian-z0"
./build/mbgl-render-test-runner --manifestPath metrics/linux-clang8-release-style.json --filter "query-tests/edge-cases/null-island"

This script compiles and then runs the render tests, that were broken by #270. Note that there is one more render test which is broken, something like enlarge-both, but this one was already broken before #270...

[ntadej]

I will object to this right now. Compared to the other fix, none of these changes (especially the minSectionLength one look wrong.

Can you please paste the failing test results?

[wipfli]

On main, 11 tests fail when running ./build/mbgl-render-test-runner --manifestPath metrics/linux-clang8-release-style.json

Here is the test output: https://wipfli.github.io/debug-maplibre-gl-native/main-linux-clang8-release-style.html

[ntadej]

On main, 11 tests fail when running ./build/mbgl-render-test-runner --manifestPath metrics/linux-clang8-release-style.json

Here is the test output: https://wipfli.github.io/debug-maplibre-gl-native/main-linux-clang8-release-style.html

Thanks. Looking into it.

Note that for posterity it may be useful to attach images to the PR.

[wipfli]

Good idea, @ntadej. Here are some screenshots:

[ntadej]

Found all the issues. Sorry again for causing them. As I said, will try to enable some more warnings to be able to spot them easier.

[wipfli]

Don't worry about it. I think the changes in #270 are good and probably we can iron out the typos with the render tests now...

[ntadej]

OK for the last change. Can you:

• change the type back to int
• add static casts to int to each assignment (when calling std::min)
• remove redundant static_casts below when this variable is used.

[ntadej]

Thanks for identifying the problematic files, @wipfli. Looks good to me now.

Note that at least the intersection detection code is very strange and it would be good to understand it.