Update MapLibre GL JS to 49bc4ca45

[github-actions]

No description provided.

[ntadej]

Not sure why the CI is not running. I think GitHub got confused :(

[ntadej]

OK close/reopen has triggered them.

[wipfli]

I run the render tests on ubuntu with the following commands:

git clone --recurse-submodules -j8 https://github.com/maplibre/maplibre-gl-native.git
cd maplibre-gl-native

# checkout pull request
gh pr checkout 359
git submodule update --init --recursive

# build stuff
cmake . -B build -G Ninja -DCMAKE_CXX_COMPILER_LAUNCHER=ccache -DCMAKE_C_COMPILER=gcc-10 -DCMAKE_CXX_COMPILER=g++-10
cmake --build build -j $(nproc 2>/dev/null || sysctl -n hw.ncpu 2>/dev/null)

# run render test
./build/mbgl-render-test-runner --manifestPath metrics/linux-clang8-release-style.json &> render-test.log

# remove color stuff from log file
sed -i 's/\x1b\[[0-9;]*m//g' render-test.log 

The result is 30 failing tests.

[wipfli]

The failed tests are:

➜  maplibre-gl-native git:(update-gl-js-to-49bc4ca45) ✗ cat render-test.log | grep "* failed"                      
* failed render-tests/line-gradient/gradient
* failed render-tests/line-gradient/translucent
* failed render-tests/line-gradient/gradient-tile-boundaries
* failed render-tests/symbol-placement/line-center
* failed render-tests/symbol-placement/line-center-tile-map-mode
* failed render-tests/runtime-styling/image-update-pattern
* failed render-tests/runtime-styling/image-add-pattern
* failed render-tests/regressions/mapbox-gl-js#5978
* failed render-tests/regressions/mapbox-gl-js#3107
* failed render-tests/regressions/mapbox-gl-native#9976
* failed render-tests/regressions/mapbox-gl-js#8273
* failed render-tests/regressions/mapbox-gl-js#5911a
* failed render-tests/regressions/mapbox-gl-js#2533
* failed render-tests/map-mode/tile-avoid-edges
* failed render-tests/text-keep-upright/line-placement-true-pitched
* failed render-tests/icon-text-fit/enlargen-both
* failed render-tests/debug/collision-lines
* failed render-tests/debug/collision-lines-overscaled
* failed render-tests/debug/collision-icon-text-line-translate
* failed render-tests/debug/collision-lines-pitched
* failed render-tests/line-pattern/pitch
* failed render-tests/line-pattern/step-curve
* failed render-tests/line-pattern/zoom-expression
* failed render-tests/line-pattern/property-function
* failed render-tests/line-pattern/literal
* failed render-tests/line-pattern/overscaled
* failed render-tests/line-pattern/@2x
* failed render-tests/fill-opacity/property-function-pattern
* failed render-tests/fill-pattern/case-data-expression
* failed render-tests/fill-pattern/wrapping-with-interpolation
* failed render-tests/fill-pattern/uneven-pattern
* failed render-tests/fill-pattern/@2x
* failed render-tests/within/filter-with-inlined-geojson
* failed query-tests/regressions/mapbox-gl-js#8999-2
* failed query-tests/regressions/mapbox-gl-js#10074

[wipfli]

Not sure why the CI is not running. I think GitHub got confused :(

I think CI was not triggered because a workflow cannot trigger another workflow or something like that... The close and reopen seems like a good manual trigger solution.

[ntadej]

Are test references shared between JS and native?

[wipfli]

https://wipfli.github.io/debug-maplibre-gl-native/linux-clang8-release-style.html is the current render test output.

[wipfli]

Yes

[wipfli]

The expected.png files are in the maplibre-gl-js submodule. For example here:

https://github.com/maplibre/maplibre-gl-js/blob/9489d7654ef9bb36a44c9b98446b84eccb98628a/test/integration/render-tests/line-gradient/gradient/expected.png

[wipfli]

Let me paste some failing test output images here.

There are some related to gradients:

Then there are some related to these little collision debug circles:

And finally there are some which see related to patterns:

[wipfli]

It is actually quite cool that the render tests are shared between JS and native. This means that the libraries render stuff the same way down to the single pixel level...

[wipfli]

As horrible as it seems, I think the easiest now is to take the GL JS submodule where it is pinned in main, and slowly move it forward in the commit history until something breaks...

[wipfli]

Closing this for now. I would like to update the submodule step by step and for that we need render tests in CI.

[wipfli]

CI render tests: #357