Feature/ios performances #44
Conversation
matteocrippa
commented
Mar 8, 2021
matteocrippa
commented
- iOS fixes background animation error on heading (old patch sent to official repo but never accepted)
- port fix for snapshot crash
# Conflicts: # .gitignore
|
Thank you! I am wondering - do files under |
| @@ -16,6 +16,8 @@ | |||
| /platform/android/build | |||
| /platform/android/MapboxGLAndroidSDK/src/main/assets/sdk_versions/com.mapbox.mapboxsdk | |||
| *.code-workspace | |||
|
|
|||
There was a problem hiding this comment.
Does Mapbox.playground allow for adding files to Git ignore?
That is, is it possible to remove the Playground binary build files by adding the following?
platform/ios/platform/ios/Mapbox.playground/build/
There was a problem hiding this comment.
Should be fine now
|
Looking good. @matteocrippa do you have any steps to follow to reproduce the crash? |
Which crash? 🐙 |
You mentioned in this PR "port fix for snapshot crash" - so i though I would test it manually on device if possible. |
|
Yeah, sorry (long day)... yeah it's the issue 485 of the mapbox repo. |
|
Got it, thanks! Related issue: mapbox/mapbox-gl-native-ios#485 |
