Update generation code for the specific case of geojson

[HarelM]

Launch Checklist

Fixes #393

• define type for GeoJSONSourceSpecification data #393

This add an ugly if to the code generation flow to facilitate the fact that the json definitions are not full enough to represent the data field in the GeoJSONSourceSpecification.
It's a very small fix and I think it adds a lot of value, so I can live with it being dirty I guess...

before:

export type GeoJSONSourceSpecification = {
	"type": "geojson";
	"data": unknown;
	"maxzoom"?: number;
	"attribution"?: string;
	"buffer"?: number;
	"filter"?: unknown;
	"tolerance"?: number;
	"cluster"?: boolean;
	"clusterRadius"?: number;
	"clusterMaxZoom"?: number;
	"clusterMinPoints"?: number;
	"clusterProperties"?: unknown;
	"lineMetrics"?: boolean;
	"generateId"?: boolean;
	"promoteId"?: PromoteIdSpecification;
};

After

export type GeoJSONSourceSpecification = {
	"type": "geojson";
	"data": GeoJSON.GeoJSON | string;
	"maxzoom"?: number;
	"attribution"?: string;
	"buffer"?: number;
	"filter"?: unknown;
	"tolerance"?: number;
	"cluster"?: boolean;
	"clusterRadius"?: number;
	"clusterMaxZoom"?: number;
	"clusterMinPoints"?: number;
	"clusterProperties"?: unknown;
	"lineMetrics"?: boolean;
	"generateId"?: boolean;
	"promoteId"?: PromoteIdSpecification;
};

• Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
• Briefly describe the changes in this PR.
• Link to related issues.
• Include before/after visuals or gifs if this PR includes visual changes.
• Add an entry to CHANGELOG.md under the ## main section.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fb3eb34) 78.06% compared to head (a57a372) 78.06%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #463   +/-   ##
=======================================
  Coverage   78.06%   78.06%           
=======================================
  Files         101      101           
  Lines        4149     4149           
  Branches     1185     1185           
=======================================
  Hits         3239     3239           
  Misses        910      910           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[louwers]

This is great!

General points:

• Maybe the file needs to be updated to make clear that it is generating TypeScript.
• I didn't try to run it. Is there any kind of CI in place to validate the output of this script? For example, to ensure that the TypeScript it generates is valid?

[HarelM]

Yes, this is a pre-build script to generate typescript files from the v8 json spec file, these files are then used to build the package and are checked during the typescript transpilation.

[HarelM]

Maybe the file needs to be updated to make clear that it is generating TypeScript.

Please propose what you think might help here.
There are two stages that generate typescript, so it might be confusing:

1. This pre-build script
2. The dts-bundle-generator which generate the d.ts files (the exported types) to be consumed by the user of this package.

[HarelM]

Ok, one last PR that I need to handle before releasing a new version which is currently stale and I need to rewrite myself.