-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix querying within feature collection of polygons #477
fix querying within feature collection of polygons #477
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #477 +/- ##
==========================================
+ Coverage 92.09% 92.20% +0.10%
==========================================
Files 100 100
Lines 4176 4182 +6
Branches 1197 1199 +2
==========================================
+ Hits 3846 3856 +10
+ Misses 330 326 -4 ☔ View full report in Codecov by Sentry. |
I've merged the addition of the expression tests. |
15f3c21
to
40f6d9f
Compare
Done. |
Did you merge from main? The coverage doesn't report the right number... |
Thanks!! Added a few nit picking... |
40f6d9f
to
e1fbd59
Compare
Done |
Can you add an item to the changelog? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THANKS!!
Fixes maplibre/maplibre-gl-js#3540
A bit verbose perhaps. But if we need to query stuff within multiple polygons, then Within.geometries has to be an array and therefore some changes are necessary here and there.
Of course this will be thoroughly tested after tests' migration from gl-js.
BTW this bug occurs not only with points but with lines too. (This is fixed here too).