Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 18 zoneless showcase #172

Closed
wants to merge 9 commits into from
Closed

Conversation

marcjulian
Copy link
Collaborator

Enables experimental zoneless for the showcase app. The map is not rendered at all, even though it uses ChangeDetectionStrategy.OnPush. OnPush is not enough to notify the map to render.

https://angular.dev/guide/experimental/zoneless#onpush-compatible-components
https://blog.angular.dev/angular-v18-is-now-available-e79d5ac0affe
CleanShot 2024-06-06 at 10 16 42

@marcjulian marcjulian mentioned this pull request Jun 6, 2024
Base automatically changed from feat/ng-18 to main June 6, 2024 08:50
@marcjulian
Copy link
Collaborator Author

I cancelled the CI as it was stuck on e2e testing

# Conflicts:
#	projects/showcase/src/app/app.config.ts
@marcjulian
Copy link
Collaborator Author

I close this PR. I'll open a new one after #178 is merged.

@marcjulian marcjulian closed this Aug 16, 2024
@marcjulian marcjulian deleted the feat/zoneless-showcase branch August 16, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant