Adding SSSOM profile for literals #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@udp do you want me to take over? |
|
@matentzn I'm off sick at the moment - feel free to finish if you like, or I'll be back next week. |
|
It also hit me a bit (some flu thing) - I think I would like it if you were to try and finish it :) |
|
note also this previous proposal: Which generalizes mapping of literals to mapping of spans in texts |
|
@udp Can you take a look at the OAK suggestion, and look at how our profile overlaps / differs? I think it would be a good thing to avoid profile proliferation, but whatever works is fine! |
matentzn
commented
Aug 1, 2023
matentzn
changed the title
jamesamcl
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #197
Fixes #234
docs/have been added/updated if necessarymake testhas been run locallyThis PR adds a new profile to SSSOM for the representation of literal mappings, leaving the default SSSOM intact.