Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

591 - SQLite3 Vulnerability #593

Closed
wants to merge 1 commit into from
Closed

Conversation

ayohrling
Copy link

This updates the @mapbox/mbtiles version in package.json to utilize
0.12.1 released about 2 years ago. This, in turn, utilizes sqlite3
version 5.x which has patched vulnerabilities.

Closes #591

This updates the `@mapbox/mbtiles` version in package.json to utilize
`0.12.1` released about 2 years ago. This, in turn, utilizes `sqlite3`
version `5.x` which has patched vulnerabilities.

Closes maptiler#591
"@mapbox/mbtiles": "0.11.0",
"@mapbox/mbtiles": "0.12.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes breaking issue as v0.12.x has dropped support for Node 10.

https://github.com/mapbox/node-mbtiles/blob/master/CHANGELOG.md#0120

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, Node10 security support ended over a year ago, we really shouldn't be basing changes and updates (especially to vulnerability-related items) on past EOL Node versions...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be tested on 14,16,18 based on current support lifecycle.

@acalcutt
Copy link
Collaborator

acalcutt commented Sep 16, 2022

This should be fixed by #602 , which was just merged and contains @mapbox/mbtiles 0.12.1

As for the node 10 support, when I tested it it seemed to work, but with the move to maplibre-native we should probably suggest newer version of node anyway, like at least node 14 with 16 recommended. The new maplibre-native binaries are built for 14,16,18 (and 10 for legacy purposes to support migration)

@petrsloup
Copy link
Member

Fixed by #602

@petrsloup petrsloup closed this Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Update to use latest mbtiles for sqlite3 vulnerability
4 participants