KevinJump#251 fix up parent check - not to fail when at root (e.g no …

…parent is ok)
marcemarc · Jul 28, 2021 · cda3cfa · cda3cfa
1 parent 79840db
commit cda3cfa
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/uSync8.ContentEdition/Serializers/DictionaryItemSerializer.cs b/uSync8.ContentEdition/Serializers/DictionaryItemSerializer.cs
@@ -49,16 +49,14 @@ protected bool HasParentItem(XElement node)
             var info = node.Element("Info");
 
             var parentItemKey = info.Element("Parent").ValueOrDefault(string.Empty);
-            if (parentItemKey != string.Empty)
+            if (!string.IsNullOrWhiteSpace(parentItemKey))
             {
                 var parent = localizationService.GetDictionaryItemByKey(parentItemKey);
-                if (parent != null)
-                {
-                    return true;
-                }
+                return parent != null;
             }
 
-            return false;
+            // if the parent is empty, then there is no parent, and that is ok.
+            return true;
         }
 
         protected override SyncAttempt<IDictionaryItem> DeserializeCore(XElement node, SyncSerializerOptions options)