Bug 1916426 - Pass our LDFLAGS last to the linker command line cargo …

…invokes r=firefox-build-system-reviewers,sergesanspaille

See llvm/llvm-project#107365 (comment)
for an example of how things can go wrong when they are passed first.

I don't think there was a specific reason for them to have been put
first in the first place.

Differential Revision: https://phabricator.services.mozilla.com/D222899

UltraBlame original commit: f6cff71bfc6cba2b1d37d79fce2cb6b5d0b00852

build/cargo-host-linker

@@ -16,10 +16,10 @@ eval
 {
 MOZ_CARGO_WRAP_HOST_LD
 }
-{
-MOZ_CARGO_WRAP_HOST_LDFLAGS
-}
 '
 "
 "
 '
+{
+MOZ_CARGO_WRAP_HOST_LDFLAGS
+}

build/cargo-host-linker.bat

@@ -15,7 +15,7 @@ extension
 MOZ_CARGO_WRAP_HOST_LD
 %
 %
-MOZ_CARGO_WRAP_HOST_LDFLAGS
+*
 %
+MOZ_CARGO_WRAP_HOST_LDFLAGS
 %
-*

build/cargo-linker

@@ -398,17 +398,8 @@ MOZ_CARGO_WRAP_LD
 ]
 args
 =
-split
-(
-os
-.
-environ
 [
-"
-MOZ_CARGO_WRAP_LDFLAGS
-"
 ]
-)
 for
 arg
 in
@@ -565,6 +556,22 @@ append
 (
 arg
 )
+args
+.
+extend
+(
+split
+(
+os
+.
+environ
+[
+"
+MOZ_CARGO_WRAP_LDFLAGS
+"
+]
+)
+)
 wrap_ld
 =
 split

build/cargo-linker.bat

@@ -4,7 +4,7 @@ off
 MOZ_CARGO_WRAP_LD
 %
 %
-MOZ_CARGO_WRAP_LDFLAGS
+*
 %
+MOZ_CARGO_WRAP_LDFLAGS
 %
-*