Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: override of 'build.cssCodeSplit' will not take effect if config.build.cssCodeSplit is undefined #148

Merged
merged 1 commit into from
Sep 27, 2024
Merged

fix: override of 'build.cssCodeSplit' will not take effect if config.build.cssCodeSplit is undefined #148

merged 1 commit into from
Sep 27, 2024

Conversation

voldikss
Copy link
Contributor

No description provided.

@voldikss voldikss marked this pull request as draft September 12, 2024 11:39
@voldikss voldikss marked this pull request as ready for review September 13, 2024 02:29
marco-prontera
marco-prontera requested changes Sep 13, 2024
View reviewed changes
Copy link
Owner

@marco-prontera marco-prontera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I think it is enough to change the code currently present in the repo with the first comment of this review and then we can proceed with the merge.

src/index.ts Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@voldikss
Copy link
Contributor Author

@marco-prontera PTAL

@voldikss
Copy link
Contributor Author

Hi @marco-prontera could this PR get merged?

@marco-prontera marco-prontera changed the base branch from main to develop September 27, 2024 06:05
@marco-prontera marco-prontera merged commit b681b37 into marco-prontera:develop Sep 27, 2024
2 checks passed
@marco-prontera marco-prontera linked an issue Sep 27, 2024 that may be closed by this pull request
[Bug]: Override of 'build.cssCodeSplit' will not take effect if config.build.cssCodeSplit is undefined #150
Closed
marco-prontera added a commit that referenced this pull request Sep 27, 2024
@marco-prontera
[#150] fix: override of 'build.cssCodeSplit' will not take effect if …
8ef2415 
…`config.build.cssCodeSplit` is `undefined` (#148)

3.5.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-prontera marco-prontera marco-prontera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Override of 'build.cssCodeSplit' will not take effect if config.build.cssCodeSplit is undefined
2 participants
@voldikss @marco-prontera