Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: listener removal (+ cleaning up all resources in full render example) #34

Merged
merged 10 commits into from
Mar 11, 2024
Merged

fix: listener removal (+ cleaning up all resources in full render example) #34

merged 10 commits into from
Mar 11, 2024

Conversation

hannojg
Copy link
Member

@hannojg hannojg commented Mar 10, 2024 •
edited
Loading

Changes

  • Introduced useRenderCallback hook (just improving the API)
  • Cleanup filament camera correctly
  • Implemented Listener remove callback to actually remove a listener
    • Removed shared_from_this from ListenerManager, and just made the _listeners a shared_ptr which simplified things
  • Removed surface listener (which hold a reference on the engine) when surface gets destroyed

@hannojg hannojg changed the title [🚧WIP] fix: listener removal (+ cleaning up all resources in full render example) fix: listener removal (+ cleaning up all resources in full render example) Mar 10, 2024
@hannojg hannojg requested a review from mrousavy March 10, 2024 11:48
@hannojg hannojg merged commit 9d5f12d into main Mar 11, 2024
@hannojg hannojg deleted the fix/listener-removal branch March 11, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrousavy mrousavy Awaiting requested review from mrousavy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannojg @mrousavy