Add more Web Platform Tests #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markcellus
pushed a commit
that referenced
this pull request
Aug 18, 2022
* Add rest of Web Platform Tests * Expose `assert.deepEqual` to Web Platform Tests * `__Secure` prefixed cookies are secure * Set `sameSite` to `lax` when item is secure * Set path to `/` when name is prefixed with __Host * Default `changed` and `deleted` to empty arrays * Make sure to fail when name is empty and value includes `=` * Expires can be a date * Remove unneeded serviceworker test setup file * Move karma single run option into config file * Setup service worker registration for tests * CookieMatchType is unused * Fix service worker tests * Implement CookieStoreManager for service workers * Make sure all the servive worker tests run * Don't throw errors in `getAll` * Clean up ordered cookies after test run * Allow passing of empty object to `getAll` * Add ability to skip tests that we can't pass right now * Don't expose CookieStore on the global object * Update README * Fix tests * Update Web Platform Test * Set return type of get Symbol method
markcellus
pushed a commit
that referenced
this pull request
Aug 18, 2022
* Add rest of Web Platform Tests * Expose `assert.deepEqual` to Web Platform Tests * `__Secure` prefixed cookies are secure * Set `sameSite` to `lax` when item is secure * Set path to `/` when name is prefixed with __Host * Default `changed` and `deleted` to empty arrays * Make sure to fail when name is empty and value includes `=` * Expires can be a date * Remove unneeded serviceworker test setup file * Move karma single run option into config file * Setup service worker registration for tests * CookieMatchType is unused * Fix service worker tests * Implement CookieStoreManager for service workers * Make sure all the servive worker tests run * Don't throw errors in `getAll` * Clean up ordered cookies after test run * Allow passing of empty object to `getAll` * Add ability to skip tests that we can't pass right now * Don't expose CookieStore on the global object * Update README * Fix tests * Update Web Platform Test * Set return type of get Symbol method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refines behaviour to align with more Web Platform Tests.