Fix test errors due to missing hosts file entry #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markcellus
commented
Aug 18, 2022
| Before running tests, you'll need to add the following entry to your `/etc/hosts` file on your machine: | ||
|
|
||
| ``` | ||
| 127.0.0.1 foo.bar.localhost |
There was a problem hiding this comment.
Adding this entry to the /etc/hosts file is necessary to get tests to pass. Without it, tests can't seem to find the /test/resources/empty_sw.js file. I'm assuming it can't find it because foo.bar.localhost wasn't mapped to what's normally default localhost (127.0.0.1).
markcellus
force-pushed
the
firefox_linux_fixes
branch
2 times, most recently
from
7ba7d00
to
de0d77a
Compare
markcellus
changed the title
markcellus
force-pushed
the
next
branch
2 times, most recently
from
eab392f
to
1d12201
Compare
markcellus
force-pushed
the
firefox_linux_fixes
branch
from
de0d77a
to
875318f
Compare
markcellus
force-pushed
the
firefox_linux_fixes
branch
from
875318f
to
a046424
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes test errors that were present when running
npm run test:ts. The errors were preventing creation of new preleases via release-it, since tests must be run and must pass before a prerelease can be generated and published.Adding a missing entry to the
/etc/hostsfile was required to get it working. Please feel free to let me know if there's anything that needs clarification. 🚀