Upgrade to node 14, rework project structure slightly #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koddsson
changed the title
|
@mkay581 @keithamus; This is ready for review. I really tried to not change everything at once. This feels like a small enough change to make sense as a PR and still be impactful. |
Merged
markcellus
pushed a commit
that referenced
this pull request
Aug 18, 2022
* Upgrade to node 14, the current LTS * Rename karma.conf.js -> karma.conf.cjs * Compile TypeScript into ES2020 syntax * Fix TypeScript violations * Use `karma-chai` instead of just `chai`. * Simplify karma tests * Actually include tests in javascript in the repo * Remove chai import from tests * Convert config files to JSON * Fix some linting issues * Only lint JS and TS files * Restructure project slightly * Remove unneeded declaration file * Remove babel and karma-esm packages * Rename husky to have a cjs extension * Include all files in `dist/` in package * Update banner-cli command
markcellus
pushed a commit
that referenced
this pull request
Aug 18, 2022
* Upgrade to node 14, the current LTS * Rename karma.conf.js -> karma.conf.cjs * Compile TypeScript into ES2020 syntax * Fix TypeScript violations * Use `karma-chai` instead of just `chai`. * Simplify karma tests * Actually include tests in javascript in the repo * Remove chai import from tests * Convert config files to JSON * Fix some linting issues * Only lint JS and TS files * Restructure project slightly * Remove unneeded declaration file * Remove babel and karma-esm packages * Rename husky to have a cjs extension * Include all files in `dist/` in package * Update banner-cli command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to use node 14 which is the long-term support release at the time of writing. Had to rework the project slightly to accommodate and used the opportunity to drop some unneeded packages.
The project now compiles TypeScript into JS using the TypeScript compiler before loading it in Karma and we get to drop all the babel and karma-ESM packages for that.