Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrading to 3.0.0-alpha.3 breaks compilation #3597

Closed
esistgut opened this issue Aug 24, 2019 · 8 comments · Fixed by #7849
Closed

upgrading to 3.0.0-alpha.3 breaks compilation #3597

esistgut opened this issue Aug 24, 2019 · 8 comments · Fixed by #7849
Assignees
Labels

Comments

@esistgut
Copy link
Contributor

esistgut commented Aug 24, 2019

On my current project this:

-    "ra-core": "^3.0.0-alpha.2",
-    "ra-data-graphql-simple": "^3.0.0-alpha.1",
+    "ra-core": "^3.0.0-alpha.3",
+    "ra-data-graphql-simple": "^3.0.0-alpha.3",
-    "react-admin": "^3.0.0-alpha.2",
+    "react-admin": "^3.0.0-alpha.3",

results in this error:

Failed to compile.

./node_modules/ra-ui-materialui/esm/layout/DeviceTestWrapper.js
Module not found: Can't resolve 'css-mediaquery' in '/myproject/node_modules/ra-ui-materialui/esm/layout'
@djhi
Copy link
Contributor

djhi commented Aug 24, 2019

Sounds like an issue with your material-ui version. Try removing your node_modules and reinstall or upgrade it manually to its latest version. We might have to fix our dependencies versions though

@esistgut
Copy link
Contributor Author

I tried to upgrade every other package in my package.json, @material-ui/core was already at version 4.3.3, I removed package-lock.json and the node_modules directory and performed a fresh npm i, the error persists.

@djhi
Copy link
Contributor

djhi commented Aug 24, 2019

This is indeed an issue on our side. The css-mediaquery is used in DeviceTestWrapper which we provide to help users test their components. However, this module is in the dev dependencies...

Workaround until we publish another alpha, install it yourself:

npm install css-mediaquery

Thanks for reporting !

@fzaninotto
Copy link
Member

Fixed by #3603

@denisesenguel
Copy link

FYI this bug seems to be back. After upgrading to 4.1.4 the issue re-appeared for me and I had to manually install css-mediaquery as described above

@fzaninotto
Copy link
Member

@denisesenguel Which is the latest version that didn't have the bug for you?

@denisesenguel
Copy link

@fzaninotto I was on 4.0.3 before

@fzaninotto
Copy link
Member

OK, it must be due to the move from tsup to tsc, reintroduced in #7818. I'll reopen this issue and push a fix.

@fzaninotto fzaninotto reopened this Jun 17, 2022
fzaninotto added a commit that referenced this issue Jun 17, 2022
@fzaninotto fzaninotto self-assigned this Jun 17, 2022
Seojun-Park pushed a commit to Seojun-Park/react-admin that referenced this issue Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants