Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.9.2 design break #485

Closed
remi13131 opened this issue Mar 20, 2017 · 7 comments
Closed

0.9.2 design break #485

remi13131 opened this issue Mar 20, 2017 · 7 comments
Assignees
Labels

Comments

@remi13131
Copy link

remi13131 commented Mar 20, 2017

Hi !
With the exact same code, upgrading [ EDIT: from 0.9.1 ] to 0.9.2 breaks the Datagrid when there is an important nuimber of columns. In smaller tables, it renders fine.

Before Upgrade :
before-0 9 2-upgrade

After Upgrade :
after-0 9 2-upgrade
(Pagination buttons, edit and delete are still here if I dezoom, but they are hidden on the right. There isn't even a horizontal scrollbar to get there)

@fzaninotto
Copy link
Member

Which version did you upgrade from? I less than 0.9, it may be a duplicate of #434

@remi13131
Copy link
Author

remi13131 commented Mar 20, 2017

Oh yes sorry I forgot to mention, I upgraded from 0.9.1

I usually try to upgrade as soon as releases are available to fix BC breaks the fastest possible !

@fzaninotto
Copy link
Member

OK. It's very weird, and I can't reproduce any regression like this with my projects. Just to confirm the bug cause, can you try to remove the custom style applied to the div with prop data-reactroot and check if that fixes the problem?

image

@remi13131
Copy link
Author

remi13131 commented Mar 20, 2017

as you can see, nothing funky in the Datagrid definition, same issue in Chromium and FF, and removing custom style for data reactroot changes nothing :/

0 9 2-design-bug
0 9 2-ff-no-custom-style-bug

@fzaninotto
Copy link
Member

Maybe the issue is with filters. I see your filters are all alwaysOn. What happens when you reove some of them?

@mantis
Copy link
Contributor

mantis commented Mar 20, 2017

@fzaninotto @remi13131 Hi Remi :) - I can reproduce this between 0.9.1 and 0.9.2 and in my case, haven't done any custom styles. Interestingly it's also seems to be browser specific - Microsoft Edge seems to be fine. Google chrome Breaks. I can see Remi is using Firefox.

In my case, i've not done any custom css - only css i've used either comes from the demo app, or from the AOR itself. However, it first seems to break when the length of the filters exceed the size of the browser screen.

Note: I've also got the below going on in Edge (which may or may not be related) before the filters reach the full width of the screen.
image

@fzaninotto fzaninotto self-assigned this Mar 20, 2017
@fzaninotto fzaninotto added the bug label Mar 20, 2017
@fzaninotto
Copy link
Member

I can reproduce this with many filters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants