Update <SelectInput> to support an array of strings as choices
#10038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
commented
Jul 22, 2024
| @@ -130,6 +131,14 @@ describe('<SelectInput />', () => { | |||
| expect(options.length).toEqual(6); | |||
| expect(options[1].textContent).toEqual('Created'); | |||
| }); | |||
|
|
|||
| it('should accept strings as choices', () => { | |||
There was a problem hiding this comment.
I only tested SelectInput because the logic is shared by all selection inputs via useChoicesContext.
djhi
reviewed
Jul 23, 2024
| @@ -4,14 +4,20 @@ import { useList } from '../../controller'; | |||
| import { ChoicesContext, ChoicesContextValue } from './ChoicesContext'; | |||
|
|
|||
| export const useChoicesContext = <ChoicesType extends RaRecord = RaRecord>( | |||
There was a problem hiding this comment.
I'm surprised this doesn't trigger a TS error as RaRecord can't be a string. I believe this is because ChoicesProps in useChoices accepts any[] for choices. This might be an issue later
There was a problem hiding this comment.
We can't type the choices as users may pass anything and set the optionText and optionValue. It's never been an issue ;)
There was a problem hiding this comment.
We should not restrict the ChoicesType then but let's do that in another PR
adguernier
reviewed
Jul 23, 2024
packages/ra-ui-materialui/src/input/CheckboxGroupInput.stories.tsx
Outdated
Show resolved
Hide resolved
packages/ra-ui-materialui/src/input/AutocompleteArrayInput.stories.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: adrien guernier <adrien@marmelab.com>
djhi
approved these changes
Jul 23, 2024
fzaninotto
changed the title
<SelectInput> to support an array of strings as choices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For
SelectInputand other selection inputs, sometimes the list of options is simply an array of strings. Doing the conversion to an array of option objects isn't intuitive.Solution
Support string choices by default.
This concerns the following components:
SelectInputSelectArrayInputAutocompleteInputAutocompleteArrayInputRadioButtonGroupInputCheckboxGroupInput