Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add <ReferenceManyField storeKey> to allow more than one reference for the same resource #10132

Merged

Conversation

djhi
Copy link
Contributor

@djhi djhi commented Aug 6, 2024

Follow #10133

Problem

When you have multiple ReferenceManyField targeting the same resource, their children share the store for selection.

Solution

Allow to provide a storeKey

How To Test

Open the storybook StoreKey story for ReferenceManyField

Additional Checks

  • The PR targets master for a bugfix, or next for a feature
  • The PR includes unit tests (if not possible, describe why)
  • The PR includes one or several stories (if not possible, describe why)
  • The documentation is up to date

Also, please make sure to read the contributing guidelines.

@djhi djhi added the WIP Work In Progress label Aug 6, 2024
@fzaninotto
Copy link
Member

To be rebased on next

@djhi djhi changed the base branch from master to next August 7, 2024 07:23
@djhi djhi added RFR Ready For Review and removed WIP Work In Progress labels Aug 7, 2024
@fzaninotto fzaninotto changed the title Fix ReferenceManyField does not allow to override store key for its children selection Add <ReferenceManyField storeKey> to allow more than one reference for the same resource Aug 7, 2024
@fzaninotto fzaninotto merged commit 785a419 into next Aug 7, 2024
14 checks passed
@fzaninotto fzaninotto deleted the fix-reference-many-field-datagrid-share-selections branch August 7, 2024 09:23
@fzaninotto fzaninotto added this to the 5.2.0 milestone Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants