Avoid "no source" warning when theres a finalSource in useInput

[GuilhermeCarra]

Problem

Currently useInput is generating erroneous warnings when using ArrayInput with TextInput without source. The source is provided by useWrappedSource

        <ArrayInput source="users">
              <SimpleFormIterator>
                  <TextInput source="" />
              </SimpleFormIterator>
        </ArrayInput>

Solution

Change conditional check to finalSource

How To Test

Create an ArrayInput as indicated

Additional Checks

• The PR targets master for a bugfix, or next for a feature
• The PR includes unit tests (if not possible, describe why)
• The PR includes one or several stories (if not possible, describe why) (N/A)
• The documentation is up to date

Also, please make sure to read the contributing guidelines.

[slax57]

I agree we should change this condition, thanks for your report!

Actually I wonder if we should go even further. AFAICT this check was mainly added to make sure we won't call useController with an empty name (and also, to make TS happy).

So we should maybe replace it altogether by:

    if (
        !finalName &&
        process.env.NODE_ENV === 'development'
    ) { /* ... */ }

@fzaninotto wdyt?

[fzaninotto]

You're right, an input with no source but with a name should not raise any warning!

[GuilhermeCarra]

@slax57 @fzaninotto thanks for your feedback! Are you guys going to work on this? I saw the changes last week in useInput but I'm still getting the warnings which is making my application very slow when editing/creating
Thanks!

[slax57]

@GuilhermeCarra the changes you refer to are unrelated (you can have a look at the originating PR description to understand the context).

Regarding this PR, if you apply the changes I requested above we will be happy to merge it. Thanks!

[GuilhermeCarra]

@slax57 thanks! I've made the change 🙌

[fzaninotto]

Thanks!