Fix useFormGroup
doesn't return validation errors with react-hook-form 7.53.0
#10168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
With the latest version of react-hook-form (7.53.0 at the time of writing),
useFormGroup
no longer returns validation errors correctly.This causes issues such as the TabbedForm Tab header not being colored in red when there is a validation error on one of the inputs inside the Tab.
Solution
An issue was opened on RHF repo to let them know about this regression: react-hook-form/react-hook-form#12217
However, it seems this issue also highlights that we may not being using the form state correctly to compute the form group state, hence we figured we may as well improve the
useFormGroup
hook to be compatible with all versions of RHF.How To Test
yarn up react-hook-form
TabbedForm.spec.tsx > should set the style of any Tab button with errors on submit
and make sure it passesAdditional Checks
master
for a bugfix, ornext
for a featureAlso, please make sure to read the contributing guidelines.