Add icons to FilterButton dropdown #10186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le state if applied
7 tasks
djhi
requested changes
Sep 6, 2024
packages/ra-ui-materialui/src/list/filter/FilterButton.spec.tsx
Outdated
Show resolved
Hide resolved
| @@ -74,13 +80,18 @@ export const FilterButton = (props: FilterButtonProps) => { | |||
| } | |||
|
|
|||
| const hiddenFilters = filters.filter( | |||
There was a problem hiding this comment.
This should be renamed. allTogglableFilters?
Comment on lines
132
to
139
| setTimeout(() => { | ||
| const inputElement = document.querySelector( | ||
| `input[name='${source}']` | ||
| ) as HTMLInputElement; | ||
| if (inputElement) { | ||
| inputElement.focus(); | ||
| } | ||
| }, 50); |
There was a problem hiding this comment.
Why do we have to focus the filter input that we just removed?
|
Besides, the tests are failing |
djhi
requested changes
Sep 9, 2024
djhi
requested changes
Sep 9, 2024
packages/ra-ui-materialui/src/list/filter/FilterButton.spec.tsx
Outdated
Show resolved
Hide resolved
packages/ra-ui-materialui/src/list/filter/FilterButton.spec.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Gildas Garcia <1122076+djhi@users.noreply.github.com>
djhi
reviewed
Sep 10, 2024
packages/ra-ui-materialui/src/list/filter/FilterButton.spec.tsx
Outdated
Show resolved
Hide resolved
djhi
approved these changes
Sep 10, 2024
fzaninotto
changed the title
fzaninotto
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is no way to differentiate between filter choices and filter actions (such as save current query) in the FilterButton
when you select a filter, it disappears from the list, which changes the place of each choice item and makes it hard to remember where is the filter you want to enable ; same for the actions (Remove all filters)
To Do
Additional Checks
masterfor a bugfix, ornextfor a feature- [ ] The documentation is up to date