[WIP] Add ReferenceManyField #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fzaninotto
commented
Aug 21, 2016
fzaninotto
commented
- Refactor reference storage in reducer to make it easier to follow
- Add basic functionality
- Test edge cases
- Add unit tests
- Add documentation
fzaninotto
force-pushed
the
reference_many
branch
from
3537621
to
fe981dc
Compare
djhi
referenced
this pull request
in marmelab/javascript-boilerplate
Sep 4, 2016
Waiting for marmelab/admin-on-rest#2
3 tasks
|
Tests and doc will have to wait. I suggest we merge as is. |
| */ | ||
| export class ReferenceManyField extends Component { | ||
| componentDidMount() { | ||
| this.props.crudGetManyReference(this.props.reference, this.props.target, this.props.record.id, relatedTo(this.props.reference, this.props.record.id, this.props.resource, this.props.target)); |
There was a problem hiding this comment.
I know you like one liners but this is annoying to review on github.
const relatedField = relatedTo(this.props.reference, this.props.record.id, this.props.resource, this.props.target);
this.props.crudGetManyReference(this.props.reference, this.props.target, this.props.record.id, relatedField);same for the others in componentWillReceiveProps, mapStateToProps and ReferenceManyListField ?
|
Can't wait to use this on boilerplate :) |
djhi
referenced
this pull request
in marmelab/javascript-boilerplate
Sep 7, 2016
Waiting for marmelab/admin-on-rest#2
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.