Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for navigation via browserHistory. #30

Closed
wants to merge 1 commit into from

Conversation

STEVEOO6
Copy link

Users can supply a history object to the Admin component, in order to support using React Router's browserHistory (to make things slightly prettier).

In this case, user's can also supply a basePath string value to the Admin object to use as a entry point to the admin-on-rest UI.

For example, my website is located at http://testwebsite.com. I've set the basePath value to 'admin', so that now I can access the primary client-facing site at http://testwebsite.com and perform administration activities at http://testwebsite.com/admin.

@@ -1,6 +1,6 @@
{
"name": "admin-on-rest",
"version": "0.3.1",
"version": "0.3.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please leave versioning to the core team

@fzaninotto
Copy link
Member

I think supporting a custom basePath is required, but supporting a custom history object isn't. The reason why we published the Custom App doc is because I think that as soon as you need to do something fancy, the <Admin> component will get in your way and you shouldn't use it.

I don't want the <Admin> component to become an over-configurable beast that reinvents redux and react-router. If you know what you're doing, don't use the <Admin> component.

So please keep only the basePath stuff here.

@djhi
Copy link
Contributor

djhi commented Sep 12, 2016

You can have a custom base path already. See marmelab/javascript-boilerplate#110

@fzaninotto
Copy link
Member

@djhi right, but only with hashHistory

@djhi
Copy link
Contributor

djhi commented Sep 12, 2016

Why ? Isn't react-router hiding the history implementation from us ?

@fzaninotto
Copy link
Member

closing as no news for too long

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants