Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to disable notifications of useCheckAuth and useLogoutIfAccessDenied hooks #5255

Merged
merged 5 commits into from
Sep 18, 2020
Merged

Ability to disable notifications of useCheckAuth and useLogoutIfAccessDenied hooks #5255

merged 5 commits into from
Sep 18, 2020

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Sep 15, 2020

Implements #5178

@WiXSL WiXSL changed the title Ability to disable notification in useCheckAuth and useLogoutIfAccessDenied hooks Ability to disable notification of useCheckAuth and useLogoutIfAccessDenied hooks Sep 15, 2020
@WiXSL WiXSL changed the title Ability to disable notification of useCheckAuth and useLogoutIfAccessDenied hooks Ability to disable notifications of useCheckAuth and useLogoutIfAccessDenied hooks Sep 15, 2020
djhi
djhi approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@djhi djhi added this to the 3.9.0 milestone Sep 15, 2020
Luwangel
Luwangel reviewed Sep 15, 2020
View reviewed changes
Copy link
Contributor

@Luwangel Luwangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thanks! I think it's a good opportunity to write tests for these two hooks. Do you have time to write them?

@WiXSL
Copy link
Contributor Author

WiXSL commented Sep 16, 2020

Done!

djhi
djhi requested changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

packages/ra-core/src/auth/useCheckAuth.spec.tsx Outdated Show resolved Hide resolved
@WiXSL @djhi
Update packages/ra-core/src/auth/useCheckAuth.spec.tsx
85efefa 
Co-authored-by: Gildas Garcia <1122076+djhi@users.noreply.github.com>
Luwangel
Luwangel approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@Luwangel Luwangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@djhi djhi merged commit 451f4a8 into marmelab:next Sep 18, 2020
@WiXSL WiXSL deleted the add-disable-notification-auth branch September 18, 2020 13:56
@fzaninotto fzaninotto mentioned this pull request Sep 18, 2020
Closed
@fzaninotto fzaninotto mentioned this pull request Oct 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

@Luwangel Luwangel Luwangel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@WiXSL @djhi @Luwangel