Fix Appbar custom content flickers when loading #5434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The size of the spinner isn't exactly the same as the size of the refresh button. As a consequence, if the AppBar has a custom content, this content moves a bit when the app loads data. Making the size of the two components match exactly fixes the bug.
djhi
reviewed
Oct 22, 2020
| @@ -11,7 +11,7 @@ import RefreshIconButton from '../button/RefreshIconButton'; | |||
| const useStyles = makeStyles( | |||
| { | |||
| loader: { | |||
| margin: 14, | |||
| margin: 16, | |||
There was a problem hiding this comment.
Why don't use theme.spacing(2) ? Could use the useTheme hook in the component as well
djhi
reviewed
Oct 22, 2020
| @@ -27,8 +27,8 @@ const LoadingIndicator = props => { | |||
| <CircularProgress | |||
| className={classNames('app-loader', classes.loader, className)} | |||
| color="inherit" | |||
| size={18} | |||
| thickness={5} | |||
| size="1em" | |||
There was a problem hiding this comment.
You might want to get the theme from useTheme and apply the same spacing
djhi
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The size of the spinner isn't exactly the same as the size of the refresh button. As a consequence, if the AppBar has a custom content, this content moves a bit when the app loads data.
Making the size of the two components match exactly fixes the bug.
Before
After