Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add default value for hasShow in Show.tsx #5471

Merged
merged 1 commit into from
Nov 2, 2020
Merged

fix: add default value for hasShow in Show.tsx #5471

merged 1 commit into from
Nov 2, 2020

Commits on Nov 2, 2020

  1. fix: add default value for hasShow in Show.tsx 

    Prevents having `hasShow` on a `div` element, because `React` complains about this

```
Warning: React does not recognize the `hasShow` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `hasshow` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
    in div (created by ShowView)
    in ShowView (created by Show)
```
    @FredericEspiau
    FredericEspiau committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    7f04958 View commit details
    Browse the repository at this point in the history