Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Removed hasCreate check #5641

Conversation

nausif
Copy link

@nausif nausif commented Dec 8, 2020

Removed hasCreate check from shouldRenderEmptyPage which is on ListView Component.

Closes #5637

@djhi
Copy link
Contributor

djhi commented Dec 8, 2020

Hi and thanks for taking time to make this PR. I think that's not enough though. First, there is a linter warning. Then, the linter warning made me think about what will be displayed by default when the list is empty and there is no create view configured. Indeed, the default empty component will still show a create invite and button even though it won't be possible.

I'm not sure yet about how we want to address this. Any suggestion?

@fzaninotto
Copy link
Member

I think it should be the responsiblity of the Empty component to display something different if hasCreate is false. Because currently, lists with no crate button and empty content cannot show a custom screen.

So I'm +1 for this change, but you must add the hasCreate check in the default Empty component

@djhi
Copy link
Contributor

djhi commented Dec 18, 2020

Superseded by #5688

@djhi djhi closed this Dec 18, 2020
@nausif nausif deleted the bugfix/fix-list-view-not-displaying-empty-5637 branch June 16, 2021 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List empty property not working as expected: empty component is not displayed when list is empty
3 participants